Olivier/colorshell
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

💥 fix(media, big-media): only show button to copy media link if it's provided by the player

Browse Source 
makes use of a connection to notify::metadata to get when the link is updated, instead of binding directly to AstalMpris.Player::metadata and getting the 'xesam:url' property, since JS does not support the hashmap thing
This commit is contained in:
retrozinndev
2025-07-29 14:18:58 -03:00
parent a67da99839
commit ba5694271d
2 changed files with 24 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ags/widget/center-window/BigMedia.tsx
+7 -12
View File
@@ -1,10 +1,9 @@
import { timeout } from "ags/time";
import { execAsync } from "ags/process";
import { Astal, Gtk } from "ags/gtk4";
import { Clipboard } from "../../scripts/clipboard";
import { player, setPlayer } from "../bar/Media";
import { getMediaUrl, player, setPlayer } from "../bar/Media";
import { Accessor, createBinding, createConnection, For, With } from "ags";
import { getPlayerIconFromBusName, pathToURI } from "../../scripts/utils";
import { getPlayerIconFromBusName, pathToURI, variableToBoolean } from "../../scripts/utils";
import AstalMpris from "gi://AstalMpris";
import AstalIO from "gi://AstalIO";
@@ -96,14 +95,10 @@ export const BigMedia = () => {
<Gtk.Box class={"controls button-row"} $type="center">
<Gtk.Button class={"link"} iconName={"edit-paste-symbolic"}
tooltipText={"Copy link to clipboard"}
visible={variableToBoolean(getMediaUrl(player))}
onClicked={() => {
execAsync(`playerctl --player=${
player.busName.replace(/^org\.mpris\.MediaPlayer2\./i, "")
} metadata xesam:url`).then(link => {
Clipboard.getDefault().copyAsync(link);
}).catch((e: Error) => {
console.error(`Media: couldn't copy media link. Stderr: \n${e.message}\n${e.stack}`);
});
const url = getMediaUrl(player).get();
url && Clipboard.getDefault().copyAsync(url);
}}
/>
<Gtk.Button class={"shuffle"} visible={createBinding(player, "shuffleStatus").as(status =>
@@ -185,10 +180,10 @@ export function PlayerSelectButton({ player, reveal, halign = Gtk.Align.CENTER,
{(pl: AstalMpris.Player) =>
<Gtk.Button class={"player"} onClicked={() => setPlayer(pl)}>
<Gtk.Box>
<Gtk.Image iconName={createBinding(player, "busName").as(
<Gtk.Image iconName={createBinding(pl, "busName").as(
getPlayerIconFromBusName
)} />
<Gtk.Label label={createBinding(player, "identity")}
<Gtk.Label label={createBinding(pl, "identity")}
hexpand={false} class={"identity"} singleLineMode
maxWidthChars={8}
/>